Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .version and use git tags instead #45

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Dec 17, 2024

Description

After trying unsuccessfully to get the workflow to create a new tag from an update to .version to work with a subsequent trigger of the build process, I thought that it might be easier and more fitting to remove the .version file and use the tags in .git instead.

Type of Change

  • Bugfix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

@svrnm svrnm requested a review from a team as a code owner December 17, 2024 13:14
svrnm and others added 5 commits December 17, 2024 15:08
Signed-off-by: Severin Neumann <[email protected]>
* initial commit mysql service

* moved mysql service to it's own section in /src

* moved mysql folder to src/databases/mysql

* updated reusable workflow
@svrnm svrnm force-pushed the remove-version-file-and-use-git-tags-instead branch from 2021260 to 49e7d9d Compare December 17, 2024 14:08
Signed-off-by: Severin Neumann <[email protected]>
@svrnm svrnm merged commit 773429d into main Dec 17, 2024
0 of 2 checks passed
@svrnm svrnm deleted the remove-version-file-and-use-git-tags-instead branch December 17, 2024 14:09
noMoreCLI added a commit that referenced this pull request Dec 20, 2024
* Remove .version and use git tags instead

Signed-off-by: Severin Neumann <[email protected]>

* remove references to .version file

Signed-off-by: Severin Neumann <[email protected]>

* Update tag-from-version.yml (#44)

* initial commit mysql service (#33)

* initial commit mysql service

* moved mysql service to it's own section in /src

* moved mysql folder to src/databases/mysql

* updated reusable workflow

* initial commit cleand up nodejs service (#36)

---------

Signed-off-by: Severin Neumann <[email protected]>
Co-authored-by: Alexander Stoklasa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants