initial commit cleand up nodejs service #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svrnm
requested changes
Dec 17, 2024
src/services/examples/backend.json
Outdated
There was a problem hiding this comment.
those files should be untouched, can you merge the latest main into this branch and then see what happens? Because those files now live in examples/docker-compose
src/services/nodejs/node.log
Outdated
There was a problem hiding this comment.
remove that from the PR and add node.log to .gitignore
svrnm
pushed a commit
that referenced
this pull request
Dec 17, 2024
svrnm
added a commit
that referenced
this pull request
Dec 17, 2024
* Remove .version and use git tags instead Signed-off-by: Severin Neumann <[email protected]> * remove references to .version file Signed-off-by: Severin Neumann <[email protected]> * Update tag-from-version.yml (#44) * initial commit mysql service (#33) * initial commit mysql service * moved mysql service to it's own section in /src * moved mysql folder to src/databases/mysql * updated reusable workflow * initial commit cleand up nodejs service (#36) --------- Signed-off-by: Severin Neumann <[email protected]> Co-authored-by: Alexander Stoklasa <[email protected]>
noMoreCLI
added a commit
that referenced
this pull request
Dec 20, 2024
* Remove .version and use git tags instead Signed-off-by: Severin Neumann <[email protected]> * remove references to .version file Signed-off-by: Severin Neumann <[email protected]> * Update tag-from-version.yml (#44) * initial commit mysql service (#33) * initial commit mysql service * moved mysql service to it's own section in /src * moved mysql folder to src/databases/mysql * updated reusable workflow * initial commit cleand up nodejs service (#36) --------- Signed-off-by: Severin Neumann <[email protected]> Co-authored-by: Alexander Stoklasa <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial commit NodeJS service
implements #25
Type of Change
Checklist