BUG: Fix backend domain parameter creation #790
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
The Integration and Staging-cd (develop) have a conflicting parameter being created in the Terraform.
The terraform is setting the staging/domain variable to api.integration when it should remain api.staging-cd
Recreate:
Deploy Integration then deploy staging-cd. Integration will succeed but then staging-cd will get this error in the backend deploy:
Error:
Error: V1 - Make sure the 'api.integration.crossfeed.cyber.dhs.gov' exists.
Unable to create base path mapping for 'api.integration.crossfeed.cyber.dhs.gov':
Base path already exists for this domain name
at APIGatewayV1Wrapper. (/home/runner/work/XFD/XFD/backend/node_modules/serverless-domain-manager/dist/src/aws/api-gateway-v1-wrapper.js:104:23)
at Generator.throw ()
at rejected (/home/runner/work/XFD/XFD/backend/node_modules/serverless-domain-manager/dist/src/aws/api-gateway-v1-wrapper.js:6:65)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
💭 Motivation and context
Staging-cd backend deployment fails after running the integration deployment.
🧪 Testing
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist