Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add utility to update the data dictionary Excel file #766

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add utility to update the data dictionary Excel file #766

wants to merge 3 commits into from

Conversation

rapidray12
Copy link
Collaborator

@rapidray12 rapidray12 commented Jan 17, 2025 •
edited by aloftus23
Loading

The initial version of the data dictionary create/update tool

🗣 Description

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@rapidray12
Create dataDictionary.py
bf7040f 
The initial version of the data dictionary create/update tool
hawkishpolicy
hawkishpolicy approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@hawkishpolicy hawkishpolicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

hawkishpolicy
hawkishpolicy reviewed Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@hawkishpolicy hawkishpolicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These frontend vulnerabilities look like the ones I resolved earlier. Are they new or does Develop need to be merged?

What of the linting errors?

nickviola
nickviola approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aloftus23
Copy link
Contributor

These frontend vulnerabilities look like the ones I resolved earlier. Are they new or does Develop need to be merged?

What of the linting errors?

Resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkishpolicy hawkishpolicy hawkishpolicy approved these changes

@nickviola nickviola nickviola approved these changes

@jayjaybunce jayjaybunce jayjaybunce approved these changes

@aloftus23 aloftus23 Awaiting requested review from aloftus23 aloftus23 is a code owner

@cduhn17 cduhn17 Awaiting requested review from cduhn17 cduhn17 is a code owner

@Matthew-Grayson Matthew-Grayson Awaiting requested review from Matthew-Grayson Matthew-Grayson is a code owner

@schmelz21 schmelz21 Awaiting requested review from schmelz21 schmelz21 is a code owner

Assignees

@rapidray12 rapidray12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rapidray12 @aloftus23 @nickviola @jayjaybunce @hawkishpolicy