Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate OCC review feedback into the Teams baseline #722

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Integrate OCC review feedback into the Teams baseline #722

merged 3 commits into from
Dec 13, 2023

Conversation

nanda-katikaneni
Copy link
Collaborator

🗣 Description

This update includes the following changes to the Teams security configuration baseline:

  • Update the front matter language to be consistent with all other baseline documents
  • Remove acknowledgements section
  • Minor grammar changes throughout

This update does NOT include any materially significant changes to the number of or content in policy items in the baseline itself that would require a change in settings to align with the baseline recommendations.

##💭 Motivation and context##
This update integrates feedback from OCC into the baselines to improve overall consistency of language and inclusion of agency standard disclaimers.

Closes #716

##🧪 Testing##
Open the associated branch and view both the raw and rendered versions of the baseline to see the final product.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@nanda-katikaneni nanda-katikaneni added the baseline-document Issues relating to the text in the baseline documents themselves label Dec 8, 2023
@nanda-katikaneni nanda-katikaneni added this to the Emerald milestone Dec 8, 2023
@nanda-katikaneni nanda-katikaneni self-assigned this Dec 11, 2023
buidav
buidav requested changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@buidav buidav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

baselines/teams.md Outdated Show resolved Hide resolved
baselines/teams.md Outdated Show resolved Hide resolved
nanda-katikaneni and others added 2 commits December 12, 2023 20:24
ahuynhMITRE
ahuynhMITRE approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@ahuynhMITRE ahuynhMITRE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no further comments

@nanda-katikaneni nanda-katikaneni merged commit f313fed into main Dec 13, 2023
8 checks passed
@nanda-katikaneni nanda-katikaneni deleted the 716-integrate-occ-teams-feedback branch December 13, 2023 17:04
twneale pushed a commit that referenced this pull request Jan 9, 2024
@nanda-katikaneni @buidav
Integrate OCC review feedback into the Teams baseline (#722)
ea9f78d 
* updating teams baseline with occ feedback

* Update baselines/teams.md

Co-authored-by: David Bui <[email protected]>

* Update baselines/teams.md

Co-authored-by: David Bui <[email protected]>

---------

Co-authored-by: David Bui <[email protected]>
Sloane4 pushed a commit that referenced this pull request Jan 11, 2024
@nanda-katikaneni @buidav @Sloane4
Integrate OCC review feedback into the Teams baseline (#722)
d6ad325 
* updating teams baseline with occ feedback

* Update baselines/teams.md

Co-authored-by: David Bui <[email protected]>

* Update baselines/teams.md

Co-authored-by: David Bui <[email protected]>

---------

Co-authored-by: David Bui <[email protected]>
kennethpalmer pushed a commit that referenced this pull request Jan 19, 2024
@nanda-katikaneni @buidav @kennethpalmer
Integrate OCC review feedback into the Teams baseline (#722)
88966c9 
* updating teams baseline with occ feedback

* Update baselines/teams.md

Co-authored-by: David Bui <[email protected]>

* Update baselines/teams.md

Co-authored-by: David Bui <[email protected]>

---------

Co-authored-by: David Bui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buidav buidav buidav approved these changes

@ahuynhMITRE ahuynhMITRE ahuynhMITRE approved these changes

Assignees

@nanda-katikaneni nanda-katikaneni

Labels
baseline-document Issues relating to the text in the baseline documents themselves
Projects
None yet
Milestone
Emerald
Development

Successfully merging this pull request may close these issues.

Integrate OCC review feedback into the Teams baseline
3 participants
@nanda-katikaneni @buidav @ahuynhMITRE