Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate OCC review feedback into the Power Bi baseline #719

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

adhilto
Copy link
Collaborator

@adhilto adhilto commented Dec 7, 2023

🗣 Description

This update includes the following changes to the PowerBI security configuration baseline:

  • Changes to improve overall consistency of format and language throughout
  • Language and verbiage updates for increased reader clarity

This update does NOT include any materially significant changes to the number of or content in policy items in the baseline itself that would require a change in settings to align with the baseline recommendations.

💭 Motivation and context

The updates included further refine and improve the overall readability and clarity of the baseline document. The result should be a baseline that is easier to interpret and use as a reference for M365 tenant administrators.

Closes #714

🧪 Testing

Compare the separately provided Word version with track changes of the PowerBI baseline document with the changes in the markdown in this branch. Accepted/modified suggested changes as appropriate and mirrored in markdown, rejected and additional changes commented in Word and sync'd to markdown as needed.

Manual review of markdown and helps ensure that the automated markdown test on the PR passes.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

✅ Post-merge checklist

@adhilto adhilto added the baseline-document Issues relating to the text in the baseline documents themselves label Dec 7, 2023
@adhilto adhilto added this to the Emerald milestone Dec 7, 2023
@adhilto adhilto requested review from buidav and ahuynhMITRE December 7, 2023 23:15
@adhilto adhilto self-assigned this Dec 7, 2023
@adhilto adhilto linked an issue Dec 7, 2023 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@buidav buidav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing we noticed was acknowledgments were silently removed. remove the section from the markdowns here as well.

@adhilto adhilto requested a review from buidav December 11, 2023 17:19
@nanda-katikaneni nanda-katikaneni merged commit ea3a707 into main Dec 13, 2023
4 checks passed
@nanda-katikaneni nanda-katikaneni deleted the 714-occ-feedback-power-bi branch December 13, 2023 13:43
twneale pushed a commit that referenced this pull request Jan 9, 2024
* Add legal disclaimer and appendix headers

* Remove Acknowledgements section
Sloane4 pushed a commit that referenced this pull request Jan 11, 2024
* Add legal disclaimer and appendix headers

* Remove Acknowledgements section
kennethpalmer pushed a commit that referenced this pull request Jan 19, 2024
* Add legal disclaimer and appendix headers

* Remove Acknowledgements section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
baseline-document Issues relating to the text in the baseline documents themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate OCC review feedback into the Power Bi baseline
4 participants