-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test the output of ScubaGear's basic commands #1538
Open
james-garriss
wants to merge
93
commits into
main
Choose a base branch
from
1490-check-output-of-basic-commands
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+171
−99
Open
Changes from all commits
Commits
Show all changes
93 commits
Select commit
Hold shift + click to select a range
24bbb46
add dispatch
james-garriss 67317a3
add push for testing
james-garriss 09af0f3
temp replace secrets
james-garriss 761cb7d
fix key vault
james-garriss f759803
write the info
james-garriss 728a3b1
set specific info
james-garriss 86bf6ad
add error
james-garriss c7849ce
fix name
james-garriss bca5ab6
fix errors
james-garriss a3be6fa
Correct newline
james-garriss 4796791
Fix newline
james-garriss 450f730
continue to next line
james-garriss 9291a42
Another newline fix
james-garriss c3cea2f
another output
james-garriss a458ca0
remove whitespace
james-garriss 96b0ae5
Clean up, should pass
james-garriss 81e04bd
fix variable name
james-garriss 3eb395d
check version
james-garriss 3aba2ce
Add intentional name error
james-garriss ebe759d
add exit 1
james-garriss f994d30
fix exit code
james-garriss c969105
Fix one error.
james-garriss b20fbdd
get the module version
james-garriss 869ffbc
use actual version
james-garriss 27f9eb2
add comments to find version problem
james-garriss 1601fde
comments for version
james-garriss 9c8116d
add comment
james-garriss f0978d0
Restore comments and version
james-garriss 0a02517
use write-debug
james-garriss 899891f
use write-debug
james-garriss 685fefc
switch to warning
james-garriss ccfd135
try black magic
james-garriss df841eb
try black magic
james-garriss 3d1d456
Set correct version number
james-garriss 2a6187e
check initiliaze output
james-garriss 17c3e63
clarify output
james-garriss f9a9180
Fix typo
james-garriss dcaf216
Trivial change
james-garriss 616231d
Remove comment from output
james-garriss 17681c0
Add outputs for initialize.
james-garriss de86b44
removed write-host
james-garriss f7d2d4d
process the output
james-garriss 1982593
replace Python w PowerShell.
james-garriss 0066977
Put output up to Pester tests
james-garriss ff82f25
Update outputs
james-garriss 19d34e5
fix global var name
james-garriss 40baebb
Fix output var in Pester
james-garriss ebf2edc
test autotrust
james-garriss c1b1a47
lint
james-garriss 3d7aadb
add key value tests
james-garriss 9980f19
adjust pester test
james-garriss d9a864c
remove dir output
james-garriss 2aca557
Comment dir
james-garriss 2dcfc03
remove dir
james-garriss e0dae41
Continue hunt for dir
james-garriss bfb7293
lint
james-garriss 669edbb
find hidden output
james-garriss 0db083d
improve writes
james-garriss 5857ea4
use value
james-garriss 58af250
more debugging comments
james-garriss cbceac6
add comments
james-garriss a9bd4f9
Lint
james-garriss 0ff26aa
comment
james-garriss 2f16a6a
comment
james-garriss 75b4f60
comment
james-garriss 28c9d76
clear function results
james-garriss ccb4f79
undo comments
james-garriss 48e1f2f
fix typo
james-garriss f916286
differentiate string from other types
james-garriss dddcf1a
list all output types
james-garriss e781b97
test for desired strings
james-garriss 687077e
lint
james-garriss 14bfa3f
separate it sections
james-garriss 807b6e3
use global vars correctly
james-garriss 70df10e
use global vars everywhere
james-garriss 018c959
move tests
james-garriss 8448962
Fix loop error
james-garriss fef328d
Tweak outputs
james-garriss 3928dcc
trim the string
james-garriss 6798463
remove testing code
james-garriss 3abf71b
Clean up calling secrets
james-garriss 15067bb
Remove old comment
james-garriss 9b871fe
removed debugging statement
james-garriss 63d7e46
Remove debugging
james-garriss 06903ee
Remove unused comments
james-garriss e48e6e4
fix opa version
james-garriss 810e8f7
fix write-warning
james-garriss 7b5fe81
test write-verbose
james-garriss 308c81e
Removed verbose
james-garriss a1d174a
Removed return
james-garriss 12c0b44
fix extra braces
james-garriss 27acd09
use env variable
james-garriss 8213d12
Fixed comments and parameters
james-garriss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would these make more sense as env vars so they are easier to change if/when they are adjusted? Or read directly from the manifest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description is found in the manifest. I think it should be possible to read from it. The name is not found in the manifest, so it would need to be defined here (or possibly be read from some other file).
I have no idea if using an env var make more sense. Variables are variables however you create and adjust them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a DRY thing. If we decided to change the name of the tool to ScubaSomethingElse, and it was read from the manifest then you wouldn't need to update the workflow to match. So that's why I think it makes more sense. Even if it's only for some of the things at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this is a good idea and that I should attempt to do so. I think this work should be done before approving this issue, so I am going to push this into Marlin and do it there.