-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise Entra report header with new exclusion info and documentation name #1529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slightly tweaked the first sentence so that it matches up with the language we have in the config file documentation. Also we don't support exclusions for roles. Only users and groups can be excluded from policies.
Nice work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works as expected
79ff76e
to
2190658
Compare
@nanda-katikaneni This PR is ready for merge. |
…to align with the prose that is on the respective documentation page.
2190658
to
2a5c226
Compare
🗣 Description
Changes the header in the
CreateReport.psm1
module that generates the header of the Entra HTML report so no longer references the README file, but rather the overall documentation. Also adds a sentence to better explain what an exclusion is and why it is useful.💭 Motivation and context
The Entra report should provide up-to-date and accurate information for users to understand their options and point to the current documentation.
Closes #1457
🧪 Testing
Run
Invoke-SCuBA -p aad
with valid credentials to generate an Entra HTML report. View the report and verify that the new language is visible, correct, and the new link works.✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
Demonstrate changes to the team for questions and comments.
(Note: Only required for issues of size
Medium
or larger)✅ Post-merge checklist