Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct arrow direction when merging recommendations #935

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

aklapper
Copy link
Contributor

@aklapper aklapper commented Oct 3, 2024

Currently shows foo → bar but direction is inverted as the resulting entity will be named foo instead of bar.

Closes #934

Currently shows `foo → bar` but direction is inverted as
the resulting entity will be named `foo` instead of `bar`.

Signed-off-by: Andre Klapper <[email protected]>
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sduenas sduenas merged commit 2571b79 into chaoss:master Oct 10, 2024
16 checks passed
@sduenas
Copy link
Member

sduenas commented Oct 10, 2024

Thanks for the patch @aklapper . I updated your PR to include the missing changelog file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Review recommendations" has inverted item order
2 participants