Fix parsing and display of backend-specific help messages #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
vchrombie
force-pushed
the
799-fix/backend-parser-usage
branch
from
26eb44b to
e71ac87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #799
I took a stab at this bug, by setting the
progattribute inside theBackendCommand's__init__method, you ensure that the program name (prog) is set correctly when each backend is initialized. This should fix the issue with any backend.$ perceval github -h [2024-08-12 17:42:02,923] - Sir Perceval is on his quest. usage: perceval github [-h] [--category CATEGORY] [--tag TAG] [--filter-classified] [--from-date FROM_DATE] [--to-date TO_DATE] [--archive-path ARCHIVE_PATH] [--no-archive] [--fetch-archive] [--archived-since ARCHIVED_SINCE] [--no-ssl-verify] [-o OUTFILE] [--json-line] [--enterprise-url BASE_URL] [--sleep-for-rate] [--min-rate-to-sleep MIN_RATE_TO_SLEEP] [-t API_TOKEN [API_TOKEN ...]] [--github-app-id GITHUB_APP_ID] [--github-app-pk-filepath GITHUB_APP_PK_FILEPATH] [--max-items MAX_ITEMS] [--max-retries MAX_RETRIES] [--sleep-time SLEEP_TIME] owner repository$ perceval jira -h [2024-08-12 17:44:02,305] - Sir Perceval is on his quest. usage: perceval jira [-h] [--category CATEGORY] [--tag TAG] [--filter-classified] [--from-date FROM_DATE] [-u USER] [-p PASSWORD] [-t API_TOKEN] [--archive-path ARCHIVE_PATH] [--no-archive] [--fetch-archive] [--archived-since ARCHIVED_SINCE] [--no-ssl-verify] [-o OUTFILE] [--json-line] [--project PROJECT] [--cert CERT] [--max-results MAX_RESULTS] urlDo you think you need any tests for this change?
I am trying to see if I can fix the args order.I guess it cannot be fixed, check #799 (comment)
I will add the changelog file when I finish the PR.Added