Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable compilation on/for arm64 targets #6

Closed
wants to merge 1 commit into from
Closed

feat: Enable compilation on/for arm64 targets #6

wants to merge 1 commit into from

Conversation

the-wondersmith
Copy link

PR puts the inclusion of xmmintrin.h behind an if defined check to enable compiling daz for/on arm64 targets

@kmaehashi
Copy link
Member

I don't think _mm_getcsr x86 intrinsics is supported on Arm64?

@hayguen
Copy link

hayguen commented Aug 12, 2023

I don't think _mm_getcsr x86 intrinsics is supported on Arm64?

you are right. fixed this at https://github.com/hayguen/daz
but finally, on systems without SSE like ARM, the functions do nothing

@the-wondersmith
Copy link
Author

@hayguen So... (just clarifying) the PR can be closed?

@hayguen
Copy link

hayguen commented Aug 14, 2023

@the-wondersmith : IMHO yes, in case my pull request #8 would get accepted, yours would get obsoleted. but i fear, there is no reaction from @chainer ?!

in addition, your PR doesn't compile/run on ARM, that is, why i added commit 0d08e77

@the-wondersmith
Copy link
Author

@hayguen 🫡 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants