Added RPC Measure and View Constants #889
Conversation
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@songy23 @c24t @reyang Hi all, I'm the MSFT contact that was working with these students on a senior design project with this as one of the outputs (Hi @reyang , we met last summer). They've officially finished their projects, so I'm trying to help them push their changes through into the repo. It looks to me that they've cleaned up the code here, and it's unclear why the travis build is failing on a unit test. Can you help let us know if we need to do anything for that particular build/test? |
|
2 week ping, would love to drive this one through if at all possible, if anything's needed on our side, since the authors have graduated by now. |
|
@cdietschrun |
|
Looks clean now |
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and |
There was a problem hiding this comment.
Shouldn't all of these be under opencensus/stats?
| # limitations under the License. | ||
|
|
||
|
|
||
| # import rpc_measure_constants |
There was a problem hiding this comment.
What are these commented out imports for?
| Define constants used to define Measures below | ||
| see specs in documentation for opencensus-python | ||
| """ | ||
| byte = "by" |
There was a problem hiding this comment.
| byte = "by" | |
| byte = "By" |
| # (always 1 for non-streaming RPCs) | ||
| self.grpc_client_sent_messages_per_rpc = MeasureInt( | ||
| name="grpc.io/client/sent_messages_per_rpc", | ||
| description="Number of messages sent in the RPC", |
There was a problem hiding this comment.
| description="Number of messages sent in the RPC", | |
| description="Number of messages sent in the RPC (always 1 for non-streaming RPCs)", |
| # per RPC (always 1 for non-streaming RPCs) | ||
| self.grpc_client_received_messages_per_rpc = MeasureInt( | ||
| name="grpc.io/client/received_messages_per_rpc", | ||
| description="Number of response messages received per RPC", |
There was a problem hiding this comment.
| description="Number of response messages received per RPC", | |
| description="Number of response messages received per RPC (always 1 for non-streaming RPCs)", |
| # have the same value as "grpc.io/server/latency" | ||
| self.grpc_client_server_latency = MeasureFloat( | ||
| name="grpc.io/client/server_latency", | ||
| description="Server latency in msecs", |
There was a problem hiding this comment.
| description="Server latency in msecs", | |
| description="Propagated from the server and should have the same value as "grpc.io/server/latency", |
| # including those that have not completed | ||
| self.grpc_client_started_rpcs = MeasureInt( | ||
| name="grpc.io/client/started_rpcs", | ||
| description="Number of started client RPCs.", |
There was a problem hiding this comment.
Please use the exact descriptions that are listed in the specs.
| description="Received bytes per RPC", | ||
| columns=[rpc_m_c.grpc_server_method], | ||
| measure=rpc_m_c.grpc_server_received_bytes_per_rpc, | ||
| aggregation=sum) |
| description="Sent bytes per RPC", | ||
| columns=[rpc_m_c.grpc_server_method], | ||
| measure=rpc_m_c.grpc_server_sent_bytes_per_method, | ||
| aggregation=sum) |
We (myself and @anamnavi) have been working on resolving issue #276 alongside Microsoft's Quantum Computing Team for code review, quality control, etc. in relation to RPC zpages written in Python.
As per the requirements of the opencensus specs document, we implemented the RPC View and Measure Constants. You can find them within opencensus/grpc under the names rpc_measure_constants.py and rpc_view_constants.py. We have included test files under the names rpc_m_c_test.py and rpc_v_c_test.py, respectively.
For further inquiry, you can reach me at [email protected] or [email protected] and @anamnavi at [email protected] or [email protected].