-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added note on root logger level #872
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@@ -37,6 +37,19 @@ This example shows how to send a warning level log to Azure Monitor. | |||
logger.addHandler(AzureLogHandler(connection_string='InstrumentationKey=<your-instrumentation_key-here>')) | |||
logger.warning('Hello, World!') | |||
|
|||
**IMPORTANT NOTE:** | |||
The root logger for the Python logging library has a logging level set to `WARNING <https://docs.python.org/3/library/logging.html#logging.Logger.setLevel>`_. Any logs that are below this level will not actually be logged, and as such, not sent to Application Insights. More on that `here <https://docs.python.org/3/library/logging.html#logging-levels>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The root logger for the Python logging library has a logging level set to `WARNING <https://docs.python.org/3/library/logging.html#logging.Logger.setLevel>`_. Any logs that are below this level will not actually be logged, and as such, not sent to Application Insights. More on that `here <https://docs.python.org/3/library/logging.html#logging-levels>`_. | |
The root logger for the Python logging library has a logging level set to `WARNING <https://docs.python.org/3/library/logging.html#logging.Logger.setLevel>`_ by default. Any logs that are below this level will not actually be logged, and as such, not sent to Application Insights. More on that `here <https://docs.python.org/3/library/logging.html#logging-levels>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! You can pull the latest master to rebase and I'll get this merged.
#871 for context.