This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Add FormatStatsPath to ochttp Transport to reduce stats path cardinality #1229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
ochttp.Transport
to accept an optionalFormatStatsPath
which is supplied toochttp.statsTransport
.FormatStatsPath
can override a request URL's path parameter to reduce cardinality for stats similar toFormatSpanName
.This should be useful when a resource id is part of a request path such as
/posts/1
or/posts/2
. Currently each resource is treated as a unique path but it would be nice to optionally treat these requests as a single path.Without FormatStatsPath specified
With FormatStatsPath specified