Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Save notifications until dismissed #945

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(ui): Save notifications until dismissed #945

wants to merge 1 commit into from

Conversation

Sotatek-DukeVu
Copy link
Collaborator

@Sotatek-DukeVu Sotatek-DukeVu commented Feb 10, 2025 •
edited
Loading

Description

Save notifications until dismissed

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: link

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

Delete when swipe

Screen.Recording.2025-02-10.at.16.45.42.mov

IOS

Screenshot 2025-02-10 at 16 25 02 Screenshot 2025-02-10 at 16 25 13 Screenshot 2025-02-10 at 16 25 27

Android

Screenshot_20250210_163145

Screenshot_20250210_163153

Screenshot_20250210_163159

@Sotatek-DukeVu Sotatek-DukeVu requested review from sdisalvo-crd and removed request for jimcase February 10, 2025 10:04
@Sotatek-DukeVu Sotatek-DukeVu self-assigned this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iFergal iFergal Awaiting requested review from iFergal iFergal is a code owner

@sdisalvo-crd sdisalvo-crd Awaiting requested review from sdisalvo-crd

At least 1 approving review is required to merge this pull request.

Assignees

@Sotatek-DukeVu Sotatek-DukeVu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sotatek-DukeVu