-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to SRE Workbook. #21
Conversation
Awesome! You beat me to it, testing now |
I found a lot of
messages in the output, for both books. Not sure if this is a regression, but it seems that most of the links are still there and working, at least in the PDF format – I was able to generate all formats of both books from this branch. I will play-test them today. Thanks! |
The updates are great! Both books are showing up with images properly included in the pages now, on mobi format. You have done a better job fixing this up than I was prepared to do. I will see if I can find out more about the apparently broken links, but I only found working links while I was browsing through the content myself, so apparently if there are broken links, it's only some of them. The irony is also not lost on me that I am reading Google's SRE books on Amazon's reader device, ha ha... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Thanks a lot @aabouzaid, this looks great 💯 Now that we have both books covered, I've created an issue to track typesetting or other reading issues: #22 Will take them up one by one, but feel free to add issues there. |
These changes to make the scripts more generic to add support to SRE Workbook.
Now we can generate books based on env variable.
e.g. to generate The Site Reliability Workbook (2018) book (after using image from this PR of course)
This fixes issue no. #19
Thanks.