-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: TransitAgency
Eligibility API fields
#2280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
back-end
Django views, sessions, middleware, models, migrations etc.
migrations
[auto] Review for potential model changes/needed data migrations updates
deployment-dev
[auto] Changes that will trigger a deploy if merged to dev
tests
Related to automated testing (unit, UI, integration, etc.)
labels
Aug 6, 2024
thekaveman
force-pushed
the
refactor/models-transitagency
branch
from
August 6, 2024 21:32
3f9f613
to
fce28f5
Compare
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
thekaveman
changed the title
Refactor:
Refactor: Aug 6, 2024
TransitAgency
updatesTransitAgency
Eligibility API fields
thekaveman
force-pushed
the
refactor/models-transitagency
branch
from
August 6, 2024 21:38
fce28f5
to
98e9d1a
Compare
thekaveman
force-pushed
the
refactor/models-transitagency
branch
from
August 7, 2024 18:09
98e9d1a
to
72c180f
Compare
@machikoyasuda do you mind taking a look at this one? |
thekaveman
force-pushed
the
refactor/models-transitagency
branch
from
August 7, 2024 21:00
72c180f
to
290c208
Compare
machikoyasuda
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
back-end
Django views, sessions, middleware, models, migrations etc.
deployment-dev
[auto] Changes that will trigger a deploy if merged to dev
migrations
[auto] Review for potential model changes/needed data migrations updates
tests
Related to automated testing (unit, UI, integration, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2234
Fairly straightforward field renames here. Nothing fancy in terms of the migration, just renaming fields and then adding
help_text
.Things to check locally
main
branchlocal_fixtures.json
(or edit whatever fixture file you are using to add values to existingTransitAgency
fields updated by this PR)bin/reset_db.sh
(now your local DB mirrors the structure ofdev
)bin/init.sh
(running this PR's migration on top of existing DB structure)TransitAgency
model