Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: TransitAgency Eligibility API fields #2280

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Aug 6, 2024

Closes #2234

Fairly straightforward field renames here. Nothing fancy in terms of the migration, just renaming fields and then adding help_text.

Things to check locally

  1. Checkout the main branch
  2. Use local_fixtures.json (or edit whatever fixture file you are using to add values to existing TransitAgency fields updated by this PR)
  3. Run bin/reset_db.sh (now your local DB mirrors the structure of dev)
  4. Checkout this PR's branch
  5. Run bin/init.sh (running this PR's migration on top of existing DB structure)
  • Confirm fields renamed on TransitAgency model
  • For fields that were renamed, confirm data is migrated

@github-actions github-actions bot added back-end Django views, sessions, middleware, models, migrations etc. migrations [auto] Review for potential model changes/needed data migrations updates deployment-dev [auto] Changes that will trigger a deploy if merged to dev tests Related to automated testing (unit, UI, integration, etc.) labels Aug 6, 2024
@thekaveman thekaveman force-pushed the refactor/models-transitagency branch from 3f9f613 to fce28f5 Compare August 6, 2024 21:32
Copy link

github-actions bot commented Aug 6, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  benefits/core
  models.py
  views.py
  benefits/eligibility
  verify.py
Project Total  

This report was generated by python-coverage-comment-action

@thekaveman thekaveman added this to the Admin tool: agency users milestone Aug 6, 2024
@thekaveman thekaveman changed the title Refactor: TransitAgency updates Refactor: TransitAgency Eligibility API fields Aug 6, 2024
@thekaveman thekaveman self-assigned this Aug 6, 2024
@thekaveman thekaveman force-pushed the refactor/models-transitagency branch from fce28f5 to 98e9d1a Compare August 6, 2024 21:38
@thekaveman thekaveman marked this pull request as ready for review August 6, 2024 21:40
@thekaveman thekaveman requested a review from a team as a code owner August 6, 2024 21:40
@thekaveman thekaveman force-pushed the refactor/models-transitagency branch from 98e9d1a to 72c180f Compare August 7, 2024 18:09
@thekaveman
Copy link
Member Author

@machikoyasuda do you mind taking a look at this one?

@thekaveman thekaveman force-pushed the refactor/models-transitagency branch from 72c180f to 290c208 Compare August 7, 2024 21:00
Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed new field names and data migrated

image

@thekaveman thekaveman merged commit 95d915b into main Aug 7, 2024
15 checks passed
@thekaveman thekaveman deleted the refactor/models-transitagency branch August 7, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev migrations [auto] Review for potential model changes/needed data migrations updates tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model refactor: TransitAgency
2 participants