Feat: set language code on Littlepay overlay #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deployment-dev
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
lalver1
changed the title
lalver1
force-pushed
the
feat/littlepay-user-language
branch
3 times, most recently
from
01b360d
to
e01c6cd
Compare
thekaveman
requested changes
Jul 26, 2024
lalver1
force-pushed
the
feat/littlepay-user-language
branch
from
e01c6cd
to
757551d
Compare
|
Thanks for the suggestions @thekaveman and @angela-tran , I think this one is ready for your re-review. |
thekaveman
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2195
Given that the Littlepay Hosted Card Tokenization overlay supports multiple languages, this PR uses this feature to set the overlay's language to the user's language in Benefits.
Note that the Littlepay docs list
es_419as the code forSpanish (Latin America), but this seems to be a typo since the overlay did not work with this code, instead it does work withes-419.Steps for testing
Run through a complete flow until you get to the enrollment index page. Then, change languages in Benefits and close/open the overlay to see the overlay in the language that was selected in Benefits.