Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Spanish translations for 500, user enrollment error #2095

Merged
merged 3 commits into from
May 15, 2024

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented May 15, 2024

Part of #2074

Rows 21, 161, 205-207 of forTranslation tab.

@thekaveman thekaveman self-assigned this May 15, 2024
@github-actions github-actions bot added front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels May 15, 2024
Copy link

github-actions bot commented May 15, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@thekaveman thekaveman changed the base branch from dev to feat/translation-spanish-lalver1 May 15, 2024 14:55
@thekaveman thekaveman marked this pull request as ready for review May 15, 2024 14:55
@thekaveman thekaveman requested a review from a team as a code owner May 15, 2024 14:55

msgid ""
"There is a problem with the Benefits application, and we’re working to fix "
"it. Please try again in a little while."
msgstr ""
"Hay un problema con la aplicación de Beneficios y estamos trabajando para "
Copy link
Member

@angela-tran angela-tran May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should block the PR, but just noting that this translation does not follow our copy style guideline of not translating the application name

Do not translate Cal-ITP Benefits

Copy link
Member

@lalver1 lalver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thekaveman thekaveman merged commit 43bd7d9 into feat/translation-spanish-lalver1 May 15, 2024
7 checks passed
@thekaveman thekaveman deleted the feat/translations-errors branch May 15, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants