Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Spanish translations for Agency Card Eligibility Error page #2093

Merged

Conversation

angela-tran
Copy link
Member

@angela-tran angela-tran commented May 15, 2024

Part of #2075

Rows 197-199 of forTranslation tab

Row 198 was a translation for "CST Agency Card", but we needed ones for MST Courtesy Card and SBMTD Reduced Fare Mobility ID. The "MST" and "SBMTD" tabs didn't have it, so for now we just stitched together entries for MST and SBMTD using existing translations for "MST Courtesy Card" and "SBMTD Reduced Fare Mobility ID card".

@angela-tran angela-tran self-assigned this May 15, 2024
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev i18n Copy: Language files or Django i18n framework labels May 15, 2024
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@angela-tran angela-tran force-pushed the feat/spanish-agency-card-error branch from 992918f to 5a9f547 Compare May 15, 2024 14:58
@angela-tran angela-tran changed the title Feat: add Spanish translations for Agency Card Eligibility Error page Feat: Spanish translations for Agency Card Eligibility Error page May 15, 2024
@angela-tran angela-tran changed the base branch from dev to feat/translation-spanish-lalver1 May 15, 2024 15:00
@angela-tran angela-tran marked this pull request as ready for review May 15, 2024 15:04
@angela-tran angela-tran requested a review from a team as a code owner May 15, 2024 15:04
Copy link
Member

@lalver1 lalver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@angela-tran angela-tran merged commit 7e16841 into feat/translation-spanish-lalver1 May 15, 2024
8 checks passed
@angela-tran angela-tran deleted the feat/spanish-agency-card-error branch May 15, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev i18n Copy: Language files or Django i18n framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants