Refactor Cypress helper #1667
Merged
Refactor Cypress helper #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tests
thekaveman
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1443
This code, a
selectCourtesyCardtest helper method, was previously quite brittle, and would break if any new Eligibility Verifiers were added - b/c the code was going by order of verifiers -- which can change -- and not actually looking for the radio input label that says "Courtesy Cards." This method broke when we added the Veterans verifier: https://github.com/cal-itp/benefits/pull/1436/files#diff-d8c366d9dffb4c84efb0c81d20aae1435d1a10f57a019a62d8131839878b194eThis PR refactors this method by having Cypress actually look for elements to click by copy, so it will not break when we add new verifiers.