Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove alt tag from decorative icons #1654

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Fix: Remove alt tag from decorative icons #1654

merged 4 commits into from
Aug 15, 2023

Conversation

machikoyasuda
Copy link
Member

closes #1651

What this PR does

  • Add alt="" to the icon includes. Remove alt validation
  • Remove alt tag copy and call from happy bus, sad bus, contactless pay icons, id card icons

@machikoyasuda machikoyasuda added this to the Copy Improvements milestone Aug 14, 2023
@machikoyasuda machikoyasuda requested a review from a team as a code owner August 14, 2023 23:44
@machikoyasuda machikoyasuda self-assigned this Aug 14, 2023
@github-actions github-actions bot added i18n Copy: Language files or Django i18n framework deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates labels Aug 14, 2023
thekaveman
thekaveman approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@machikoyasuda machikoyasuda merged commit f806add into dev Aug 15, 2023
10 checks passed
@machikoyasuda machikoyasuda deleted the fix/1651-remove-alt-text-icons branch August 15, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indexing indexing indexing left review comments

@srhhnry srhhnry srhhnry left review comments

@thekaveman thekaveman thekaveman approved these changes

Assignees

@machikoyasuda machikoyasuda

Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework
Projects
None yet
Milestone
Copy improvements
Development

Successfully merging this pull request may close these issues.

Remove alt text from icons
4 participants
@machikoyasuda @thekaveman @srhhnry @indexing