Landing Page: Desktop - Add 72px extra padding/margin top #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
front-end
|
@srhhnry How does this look? |
|
Ready for engineering review @angela-tran |
angela-tran
approved these changes
Aug 11, 2023
|
@machikoyasuda Thanks for linking the discussion in #1641 (comment)! It was helpful for me to read through the reasoning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1637
What this PR does
Screenshots
Figma and the site side by side, when the site is the same height as the Figma mocks
Dev site vs. this PR - at taller screen widths