-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Letter-spacing #1613
Merged
Merged
Letter-spacing #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 3, 2023
machikoyasuda
force-pushed
the
fix/type-letter-spacing
branch
from
August 8, 2023 18:44
66e3060
to
681216d
Compare
machikoyasuda
force-pushed
the
fix/type-letter-spacing
branch
from
August 8, 2023 19:08
681216d
to
92b01af
Compare
machikoyasuda
force-pushed
the
fix/type-letter-spacing
branch
from
August 8, 2023 22:58
ce4f004
to
fbac12f
Compare
machikoyasuda
force-pushed
the
fix/type-letter-spacing
branch
from
August 8, 2023 22:59
fbac12f
to
5163dd1
Compare
Rebased latest dev |
@thekaveman @angela-tran this PR is rebased with the latest |
@thekaveman @angela-tran Wait sorry no it's not!!! One sec |
@thekaveman @angela-tran Nowwwww ready for review |
angela-tran
approved these changes
Aug 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1600
Status: Rebased and Ready for Review
What this PR does
h1
,h3
) - prefer to not add class or component-level overrides when the type is using the same styles as the already-styled basic elements.Testing
The browser developer tools shows letter-spacing in pixels. Make sure your Figma is in Dev Mode, with display set to Pixels, so you can compare the Figma's pixels to the browser's pixels.
H1
H2: There are 3 kinds of H2's on the app
A regular H2 where the size/letter-spacing don't change responsively,
h2, .h2
H2 that down-sizes to a P on Mobile,
.h2-sm-p
H2 that downsizes to font-size 20px on Mobile,
.h2-sm
H4
Body, Paragraph
Buttons
Previous Page