Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: language event middleware #1611

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Fix: language event middleware #1611

merged 2 commits into from
Aug 3, 2023

Conversation

thekaveman
Copy link
Member

Fixes #1374

as shown in Sentry, this endpoint can be called by e.g. scrapers
where 'language' is not included in the POST request

this fix prevents an error from being thrown (and an event from being logged)
@thekaveman thekaveman added this to the Reliability milestone Aug 2, 2023
@thekaveman thekaveman self-assigned this Aug 2, 2023
@thekaveman thekaveman requested a review from a team as a code owner August 2, 2023 22:42
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev tests Related to automated testing (unit, UI, integration, etc.) back-end Django views, sessions, middleware, models, migrations etc. labels Aug 2, 2023
* request with the wrong view function
* request with a missing language parameter
* request with a language parameter
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix and tests look good 👍

@thekaveman thekaveman merged commit c4b5110 into dev Aug 3, 2023
12 checks passed
@thekaveman thekaveman deleted the fix/language-event branch August 3, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiValueDictKeyError: 'language'
2 participants