Fix: Desktop - Login.gov modal alignment #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
front-end
machikoyasuda
force-pushed
the
fix/1575-modal-top
branch
from
f1eb39e
to
5d7f77c
Compare
|
@machikoyasuda would it make sense to override the other way here? Since the homepage Provider select modal is the different one, implement the default and override only for the homepage? |
|
@thekaveman I asked Sarah about this. She's going to be updating the Agency Provider modal for the SBMTD feature. And when she does that, she is going to align the Agency Provider modal to look more like the Info Modal. So I think we can combine the 2 modals into the same includes once she does that. 
|
|
@thekaveman Once we get the new Agency Provider modal design (for SBMTD) - which is part of Sprint 8, I suggest we:
|
thekaveman
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1575
What this PR does
This PR ensures that the 2 Login.gov modals match the design in Figma and also match the design of the 2 other modals (Contactless pay and Littlepay) in padding, margin and spacing.
modal-infoincludes for both Login.gov modals. (Side note: Why are 2 modal includes necessary? Because spacing and margins are different in seemingly small but noticeable ways between the Transit Provider Selection modal and the rest of the modals. The X icons aren't even the same. The header top padding height is totally different. The titles are differently aligned - to name a few.)Login.gov modal - Eligibility
Login.gov modal - Eligibility Start