Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help: Align desktop width to 8-col #1596

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Aug 1, 2023

fix #1576

image image

@machikoyasuda machikoyasuda added this to the Veterans milestone Aug 1, 2023
@machikoyasuda machikoyasuda requested a review from a team as a code owner August 1, 2023 00:04
@machikoyasuda machikoyasuda self-assigned this Aug 1, 2023
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates labels Aug 1, 2023
@machikoyasuda machikoyasuda changed the title Help: Align desktop width to 8. Help: Align desktop width to 8-col Aug 1, 2023
@machikoyasuda
Copy link
Member Author

Moving this outstanding question from #980 to here, for @srhhnry @angela-tran @thekaveman

Should we remove the GitHub sentence after the Go Back button? Do we have to have it? If so, it should be in the Figma...and should it come before or after the Go Back button?

@thekaveman
Copy link
Member

Do we have to have it?

Technically this is a requirement of our License:

If your software can interact with users remotely through a computer
network, you should also make sure that it provides a way for users to
get its source. For example, if your program is a web application, its
interface could display a "Source" link that leads users to an archive
of the code.

The Help page was just the only place that made sense to stick it at the time, probably makes more sense on an eventual About page. I don't think it matters where it shows up so happy to have it moved around if that works better design wise.

@machikoyasuda
Copy link
Member Author

@thekaveman Got it.

@srhhnry Do you prefer the last line with the link to the source code to be below the Go back button or above it? (Or somewhere else entirely?) Eventually - it would be more appropriate on an About page.

image

vs

image

I also wonder if the text needs some kind of subheader.

cc @indexing FYI

@srhhnry
Copy link
Member

srhhnry commented Aug 1, 2023

My suggestion is to make this a small section with a header (above the button, below the questions section). Definitely want to hear @indexing's thoughts on content, but could see a header title that says something like:

  • About Cal-ITP software
  • About Cal-ITP Benefits software
  • About our software (less inclined toward this one as we don't use the first person in the app--e.g. you not we)
  • Cal-ITP software policy (looking to 18F here)
  • Cal-ITP Benefits open source policy

I think either of the first two are my preference.

@angela-tran
Copy link
Member

My suggestion is to make this a small section with a header (above the button, below the questions section). Definitely want to hear @indexing's thoughts on content, but could see a header title...

@thekaveman @machikoyasuda Can we create a separate GH issue for this idea? This GitHub sentence has been on the Help page all this time without any problem, and I don't think it blocks anything about updating the desktop width which is what this PR is about.

@machikoyasuda machikoyasuda merged commit 88f9a97 into dev Aug 1, 2023
10 checks passed
@machikoyasuda machikoyasuda deleted the fix/1576-help-width branch August 1, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust Help page columns
4 participants