-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help: Align desktop width to 8-col #1596
Conversation
Moving this outstanding question from #980 to here, for @srhhnry @angela-tran @thekaveman Should we remove the GitHub sentence after the |
Technically this is a requirement of our License:
The Help page was just the only place that made sense to stick it at the time, probably makes more sense on an eventual About page. I don't think it matters where it shows up so happy to have it moved around if that works better design wise. |
@thekaveman Got it. @srhhnry Do you prefer the last line with the link to the source code to be below the Go back button or above it? (Or somewhere else entirely?) Eventually - it would be more appropriate on an About page. vs I also wonder if the text needs some kind of subheader. cc @indexing FYI |
My suggestion is to make this a small section with a header (above the button, below the questions section). Definitely want to hear @indexing's thoughts on content, but could see a header title that says something like:
I think either of the first two are my preference. |
@thekaveman @machikoyasuda Can we create a separate GH issue for this idea? This GitHub sentence has been on the Help page all this time without any problem, and I don't think it blocks anything about updating the desktop width which is what this PR is about. |
fix #1576