Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: punctuation for links #1570

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Chore: punctuation for links #1570

merged 4 commits into from
Jul 31, 2023

Conversation

angela-tran
Copy link
Member

@angela-tran angela-tran commented Jul 28, 2023 •
edited
Loading

Closes #1544

This PR adds punctuation after all icons that follow links (external link icon and modal icon).

See #1561 (comment)

@angela-tran angela-tran added this to the Veterans milestone Jul 28, 2023
@angela-tran angela-tran self-assigned this Jul 28, 2023
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev i18n Copy: Language files or Django i18n framework and removed deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Jul 28, 2023
@angela-tran angela-tran marked this pull request as ready for review July 31, 2023 19:45
@angela-tran angela-tran requested a review from a team as a code owner July 31, 2023 19:45
machikoyasuda
machikoyasuda approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • went thru full flow
  • checked all modals
  • existing "too much space between question mark and period" bug for this is fixed also!
image

@machikoyasuda
Copy link
Member

Also fixes #1579

@angela-tran angela-tran merged commit 239a35d into dev Jul 31, 2023
7 checks passed
@angela-tran angela-tran deleted the chore/punctuation-for-links branch July 31, 2023 21:43
@angela-tran angela-tran mentioned this pull request Jul 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machikoyasuda machikoyasuda machikoyasuda approved these changes

@thekaveman thekaveman thekaveman approved these changes

Assignees

@angela-tran angela-tran

Labels
i18n Copy: Language files or Django i18n framework
Projects
None yet
Milestone
Veteran rider enrollment pathway
Development

Successfully merging this pull request may close these issues.

Update copy for Help page
3 participants
@angela-tran @machikoyasuda @thekaveman