Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo from #9545 #9597

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Fix typo from #9545 #9597

merged 1 commit into from
Nov 12, 2024

Conversation

jder
Copy link
Contributor

@jder jder commented Nov 12, 2024

While trying to update wasmtime-py to use the latest dev version, I noticed what I think is just a typo causing a mismatch between the c header file:

WASMTIME_CONFIG_PROP(void, memory_reservation_for_growth, uint64_t)

which expands to wasmtime_config_memory_reservation_for_growth_set and this line (which still has "reserved"). I think just a typo from #9545.

@jder jder requested a review from a team as a code owner November 12, 2024 16:38
@jder jder requested review from fitzgen and removed request for a team November 12, 2024 16:38
alexcrichton
alexcrichton approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks!

@alexcrichton alexcrichton added this pull request to the merge queue Nov 12, 2024
Merged via the queue into bytecodealliance:main with commit f888bea Nov 12, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

@fitzgen fitzgen Awaiting requested review from fitzgen fitzgen is a code owner automatically assigned from bytecodealliance/wasmtime-core-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jder @alexcrichton