Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial f16 and f128 support to the aarch64 backend #9076

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

beetrees
Copy link
Contributor

@beetrees beetrees commented Aug 4, 2024

This PR adds initial support for passing f16 and f128 values around to the aarch64 backend. Support is added for the load, store, bitcast, select, f16const and f128const CLIF instructions, as well as the fp16 target feature.

As a side effect of this PR generalising aarch64 bitcast support, this PR fixes (for aarch64) #6104.

f16/f128 issue: #8312

@beetrees beetrees requested a review from a team as a code owner August 4, 2024 16:40
@beetrees beetrees requested review from cfallin and removed request for a team August 4, 2024 16:40
@beetrees beetrees force-pushed the f16-f128-aarch64-mvp branch from 6473711 to a2cbb52 Compare August 4, 2024 16:56
@beetrees beetrees requested review from a team as code owners August 4, 2024 16:56
@beetrees beetrees requested review from alexcrichton and removed request for a team August 4, 2024 16:56
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:meta Everything related to the meta-language. fuzzing Issues related to our fuzzing infrastructure isle Related to the ISLE domain-specific language wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime labels Aug 4, 2024
Copy link

github-actions bot commented Aug 4, 2024

Subscribe to Label Action

cc @cfallin, @fitzgen

This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:meta", "fuzzing", "isle", "wasmtime:api", "wasmtime:config"

Thus the following users have been cc'd because of the following labels:

  • cfallin: isle
  • fitzgen: fuzzing, isle

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link

github-actions bot commented Aug 4, 2024

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on this one -- all looks reasonable to me. Thanks for this work!

@cfallin
Copy link
Member

cfallin commented Aug 16, 2024

@beetrees this needs a rebase to latest main I think (due to my delay, sorry); happy to merge once it's ready.

@beetrees beetrees force-pushed the f16-f128-aarch64-mvp branch from a2cbb52 to b7ea393 Compare August 16, 2024 17:02
@beetrees
Copy link
Contributor Author

Rebased

@cfallin cfallin enabled auto-merge August 16, 2024 17:04
@cfallin cfallin disabled auto-merge August 16, 2024 17:14
@cfallin
Copy link
Member

cfallin commented Aug 16, 2024

@beetrees it looks like some new lints are being enforced now (CI fail) -- would you mind taking a look?

@beetrees beetrees force-pushed the f16-f128-aarch64-mvp branch from b7ea393 to b21c5fb Compare August 16, 2024 17:20
@beetrees
Copy link
Contributor Author

I've fixed the Clippy warnings.

@cfallin cfallin enabled auto-merge August 16, 2024 17:30
@cfallin cfallin added this pull request to the merge queue Aug 16, 2024
Merged via the queue into bytecodealliance:main with commit 3f5c21b Aug 16, 2024
67 checks passed
@beetrees beetrees deleted the f16-f128-aarch64-mvp branch August 16, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:meta Everything related to the meta-language. cranelift Issues related to the Cranelift code generator fuzzing Issues related to our fuzzing infrastructure isle Related to the ISLE domain-specific language wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants