Optional Broker Shutdown #929
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baxterjo
force-pushed
the
feature/rumqttd-shutdown
branch
2 times, most recently
from
27e1226 to
991341b
Compare
baxterjo
force-pushed
the
feature/rumqttd-shutdown
branch
from
991341b to
ddd0a46
Compare
baxterjo
changed the title
Instead users must fetch handle before starting broker to ensure it is cancelable.
baxterjo
force-pushed
the
feature/rumqttd-shutdown
branch
from
ddd0a46 to
4c5218d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
New feature (non-breaking change which adds functionality)
Added non-breaking version of broker handle. This differs from #878 in two major ways:
Broker::start()will not return. This ensures applications that are already embedding the broker do not encounter any unexpected behavior when upgrading to the new version.BrokerHandle's use is optional. Channel implementation will throw errors if the sender sides are dropped.Added two unit tests for new functionality.
Also upgraded
tokio-utils. Upgrade was necessary to use theCancellationToken::run_until_cancelled()method.Checklist:
cargo fmtCHANGELOG.mdif it's relevant to the users of the library. If it's not relevant mention why.