Skip to content

Commit

Permalink
Remove schema for fields with generic types, bug fixes
Browse files Browse the repository at this point in the history 
- Schema for generic types are currently not supported by controller-gen,
see kubernetes-sigs/controller-tools#844
- Fix bug in examples:
    - TaskSpec -> taskSpec
    - PipelineSpec -> pipelineSpec
  • Loading branch information
@burigolucas
burigolucas committed Jan 26, 2025
1 parent e4bbd38 commit ff2f380
Show file tree
Hide file tree
Showing 31 changed files with 558 additions and 259 deletions.
19 changes: 7 additions & 12 deletions config/300-crds/300-clustertask.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ spec:
Default is the value a parameter takes if no input value is supplied. If
default is set, a Task may be executed without a supplied value for the
parameter.
type: object
x-kubernetes-preserve-unknown-fields: true
description:
description: |-
Description is a user-facing description of the parameter that may be
Expand Down Expand Up @@ -122,6 +122,7 @@ spec:
Type is the user-specified type of the parameter. The possible types
are currently "string", "array" and "object", and "string" is the default.
type: string
x-kubernetes-list-type: atomic
resources:
description: |-
Resources is a list input and output resource to run the task
Expand Down Expand Up @@ -257,7 +258,7 @@ spec:
type: string
value:
description: Value the expression used to retrieve the value of the result from an underlying Step.
type: object
x-kubernetes-preserve-unknown-fields: true
x-kubernetes-list-type: atomic
sidecars:
description: |-
Expand Down Expand Up @@ -3370,11 +3371,8 @@ spec:
name:
type: string
value:
description: |-
ParamValue is a type that can hold a single string or string array.
Used in JSON unmarshalling so that a single JSON field can accept
either an individual string or an array of strings.
type: object
x-kubernetes-preserve-unknown-fields: true
x-kubernetes-list-type: atomic
ports:
description: |-
List of ports to expose from the Step's container. Exposing a port here gives
Expand Down Expand Up @@ -3601,11 +3599,8 @@ spec:
name:
type: string
value:
description: |-
ParamValue is a type that can hold a single string or string array.
Used in JSON unmarshalling so that a single JSON field can accept
either an individual string or an array of strings.
type: object
x-kubernetes-preserve-unknown-fields: true
x-kubernetes-list-type: atomic
resolver:
description: |-
Resolver is the name of the resolver that should perform
Expand Down
14 changes: 4 additions & 10 deletions config/300-crds/300-customrun.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,8 @@ spec:
name:
type: string
value:
description: |-
ParamValue is a type that can hold a single string or string array.
Used in JSON unmarshalling so that a single JSON field can accept
either an individual string or an array of strings.
type: object
x-kubernetes-preserve-unknown-fields: true
x-kubernetes-list-type: atomic
resolver:
description: |-
Resolver is the name of the resolver that should perform
Expand Down Expand Up @@ -144,11 +141,8 @@ spec:
name:
type: string
value:
description: |-
ParamValue is a type that can hold a single string or string array.
Used in JSON unmarshalling so that a single JSON field can accept
either an individual string or an array of strings.
type: object
x-kubernetes-preserve-unknown-fields: true
x-kubernetes-list-type: atomic
retries:
description: Used for propagating retries count to custom tasks
type: integer
Expand Down
Loading

0 comments on commit ff2f380

Please sign in to comment.