-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of multi-arch support for extension packages #2320
base: main
Are you sure you want to change the base?
Conversation
dcf618a
to
7622d59
Compare
Signed-off-by: Costas Papastathis <[email protected]>
…ension .toml file Signed-off-by: Costas Papastathis <[email protected]>
Signed-off-by: Costas Papastathis <[email protected]>
Signed-off-by: Costas Papastathis <[email protected]>
Signed-off-by: Costas Papastathis <[email protected]>
Signed-off-by: Costas Papastathis <[email protected]>
98cc239
to
3137310
Compare
@pacostas Thank you so much for this work!!! I will review it tomorrow!!! |
You are welcome, feel free to make any suggestions! :) |
@jjbustamante Hello! With respect to your time, did you have the chance to take a look on the implementation? |
@pacostas I am so sorry I haven't reviewed your PR, I will be pulling it and testing it locally, also, we are evaluating the current state of Kaniko because we are not sure how it will affect us. We use Kaniko for our extension implementation. |
Thank you very much :) Thank you for the information about kaniko, do you know if kaniko is used somewhere else except extension and if there is a discussion/thread about that issue (to be in the loop)? |
We only use Kaniko for extensions, we discussed it during our Working Group meeting on December 12th, but the recording is not on Youtube 😞 |
Summary
This implementation is based on the RFC https://github.com/buildpacks/rfcs/blob/main/text/0128-multiarch-builders-and-package.md
This PR allows the
pack extension package
to generate multi-platform OCI images and create an image index to combine them.It also adds the
--path
flag to point to a directory on the extension that needs to be packaged.This PR has not been tested in packaging a builder with multi-platform extension.
Output
Before
After
--target
flag--path
flag.Documentation
Related
Resolves #2183
Resolves #2160