Remove line number from stackcollapse-wcp output #331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now
stackcollapse-wcp.pl
keeps the file and line numbers as part of the function name (so a function is namedmain (at main.cpp:50
for example)This causes functions to be registered multiple times (see screenshots)
I'm not 100% sure, but I'd say that this is not how flame graphs work, and not a wanted behavior ?
Without patch:
![without_patch](https://private-user-images.githubusercontent.com/42669835/305759461-f464213c-9803-4eb8-a6d0-046be5f51c28.svg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MzMwNDcsIm5iZiI6MTczOTYzMjc0NywicGF0aCI6Ii80MjY2OTgzNS8zMDU3NTk0NjEtZjQ2NDIxM2MtOTgwMy00ZWI4LWE2ZDAtMDQ2YmU1ZjUxYzI4LnN2Zz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDE1MTkwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAzYjM4MDQ3ZTFkMmEyNDliNmRkOWI2OTAxNmVkMTY3Mjc5YWNjM2MwNDJmZjUzMjg0ODY2YTkzOTE1YzhkYWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.muWk0OqVb5ZTBmnrZFtauNA5rSDuQNCWvtx69QyaHW0)
With patch
![with_patch](https://private-user-images.githubusercontent.com/42669835/305759469-381e0df0-a3f8-45bc-8051-fbf30977f081.svg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MzMwNDcsIm5iZiI6MTczOTYzMjc0NywicGF0aCI6Ii80MjY2OTgzNS8zMDU3NTk0NjktMzgxZTBkZjAtYTNmOC00NWJjLTgwNTEtZmJmMzA5NzdmMDgxLnN2Zz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDE1MTkwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBkOWI2NWFkMjExMWUzYTU3NWQ2MmMzODRjZjJmZjk0YjVmZWJmNjlhMWU1MDEzNDc2MmM4NDZkMmIzMzcwMDYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.KG07rzulQ7ejmGGF1VnXxi8LEE9DOrOySlKJXMpAwK0)