Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for inline images #1287

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Ondama
Copy link

@Ondama Ondama commented Feb 17, 2018

This is related to #358

The result is this: fluid-layout.pdf

The source is:

const docDefinition = {
    pageSize: 'A4',
    pageMargins: [24, 25, 24, 23],
    content: [
        {text: ['hello', {image: 'smile'}, {text: 'world', style: 'em'}]}
    ],
    styles: {
        em: {bold: true}
    },
    images
}

@Ondama Ondama force-pushed the inline-images branch 2 times, most recently from f7ca60f to 5eba4ce Compare February 23, 2018 23:00
@danielpassos
Copy link

Any update on it?

@zahrafali
Copy link

Will this allow inline svg as well?

@th3impal3r
Copy link

bump this would be great!

@miroslavvojtus
Copy link

Hi.
We would need this feature. It is pretty basic feature in document editing.

Why is this PR waiting more than 2 years?
Is this lib maintained at all?

@thecodrr
Copy link

thecodrr commented Jul 9, 2021

@liborm85 ping

@bgl3317
Copy link

bgl3317 commented Nov 15, 2021

Can't wait for this!

@bgl3317
Copy link

bgl3317 commented Nov 16, 2021

@Ondama You don't happen to have your past solution ported over to a more recent version of pdfmake do you?

@laukacka
Copy link

@liborm85 please check it out :)

@DavMem
Copy link

DavMem commented Aug 28, 2024

thank you so much.
this still works as of today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants