Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

Hieraize and encapsulate parts à la boxen/puppet-redis #7

Closed
wants to merge 8 commits into from
Closed

Hieraize and encapsulate parts à la boxen/puppet-redis #7

wants to merge 8 commits into from

Conversation

donaldguy
Copy link

It's a lot of changes but I did my best to group them into clean changesets to make it easily reviewable

  • Following the lead of boxen/puppet-boxen use ripienaar/puppet-module-data and undef parameters to allow easy overriding of parameters by organizations, as well as individual users (in particular allow moving back to default port without forking)
  • Pass through a global ensure everywhere to allow whole cloth removal
  • Return to a "custom" formula, Fixes Outputs several errors on subsequent boxen runs #5 ; its just the homebrew one with the shims, defaults, and plist removed from the formula (and bottles 😢 )
  • Fail-fast parameter validation

Still to do (though can merge in my opinion without):

Donald Guy added 8 commits January 12, 2015 15:00
 - Since variables are now in-scope, drop to short form of reference in
   both init.pp and templates
 - Remove zookeeper::config class as it is now redundant
 - Update tests to match-ish, despite the fact that they can't run cause
   boxen/cardboard#13
Allowing for idempotency that is otherwise lost

Fixes #5
Taking cues from boxen/puppet-redis, as in donaldguy/puppet-kafka,
encapsulate the configuration state so that we can ensure whole
presence/absence, and more nicely, use a single notify arrow to
hint the puppet scheduler rather than many individual requires

Also switch to new-school boxen::env_script type rather than just
file, cleaning up after our old self.
They don't actually pass yet because of boxen/cardboard#13
As well as to disambiguate what is considered "package" if we ever
want to put it back in the homebrew formula
@rgabo
Copy link

rgabo commented Aug 18, 2015

Thank you for the great work @donaldguy, we're using both donaldguy/puppet-kafka and donaldguy/puppet-zookeeper with great success, very much appreciated.

Do you think you can cut a release here on GitHub of both Puppet modules? We've forked under sspinc for the sole reason of easily pointing to a tarball release from our Puppetfile. I would imagine that you're pointing go to your dev checkouts but we prefer:

github "kafka", "1.0.0", :repo => "donaldguy/puppet-kafka"

Thanks!

@donaldguy donaldguy closed this Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Outputs several errors on subsequent boxen runs
2 participants