Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Remove actions/checkout, fix apt commands, add retries on net errors #158

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Lastique
Copy link
Member

@Lastique Lastique commented Jul 4, 2024

GitHub actions/checkout@v3 is no longer working and v4 is incompatible with older Linux versions due to actions/checkout#1590. To fix this, and permanently eliminate the issue of periodic deprecation of actions/checkout, replace it with manual downloads of git snapshots using curl.

Additionally, fixed apt command lines that would incorrectly expand the list of packages to install. Added options to retry on network errors to reduce the probability of spurious CI failures. Also added git checkout parallel jobs to potentially speed up the checkout.

This should fix CI failures with actions/checkout@v3 and eliminate GHA deprecation warnings.

@jeking3
Copy link
Collaborator

jeking3 commented Nov 12, 2024

Don't they have an actions@current so you can stay current and risk having a build break the other way? Seems less likely; I would be surprised if they do not.

@Lastique
Copy link
Member Author

actions@current means their upgrades will randomly break CI - when they do the upgrade rather than when our maintainer does. Either way, the breakage takes place.

@Lastique
Copy link
Member Author

@pdimov @jeking3 Is this PR not going to be accepted? Do I need to update it or it can be just closed?

@pdimov
Copy link
Member

pdimov commented Nov 12, 2024

There's no need for it at the moment, but we might need it in the future when GHA breaks actions/checkout entirely on old images.

…rors.

GitHub actions/checkout@v3 is no longer working and v4 is incompatible with
older Linux versions due to actions/checkout#1590.
To fix this, and permanently eliminate the issue of periodic deprecation
of actions/checkout, replace it with manual downloads of git snapshots using
curl.

Additionally, fixed apt command lines that would incorrectly expand the list
of packages to install. Added options to retry on network errors to reduce
the probability of spurious CI failures. Also added git checkout parallel
jobs to potentially speed up the checkout.

This should fix CI failures with actions/checkout@v3 and eliminate GHA
deprecation warnings.
@Lastique Lastique force-pushed the feature/remove_actions_checkout branch from 9f3e864 to 835c364 Compare November 12, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants