Fix off-by-one error in AbstractBndMavenPlugin #6457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to aQute.service.reporter.Reporter.SetLocation.line(int) javadoc "Line 0 is the top line" but BuildContext#addMessage says "Use 1 (not 0) for the first line" so when converting from bnd location > build context we need to add one to the line. Signed-off-by: Christoph Läubrich <[email protected]>
|
@laeubi merged, since it is a simple change in logging output. |
|
You wont see this in the log but in m2e for example, before nothing was shown in the file itself (only in the problems view) or at the wrong line, after it is shown on first line or "correct" line. |
kriegfrj
changed the title
|
Title was "of-by-one", which ironically means that it was off by one (letter). I'm sorry, silly things amuse me. 😄 But I fixed it so that it won't break future searches. Thank you to all for your continuing hard work on Bnd. I'm sorry I'm not able to contribute much these days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to aQute.service.reporter.Reporter.SetLocation.line(int) javadoc "Line 0 is the top line" but BuildContext#addMessage says "Use 1 (not 0) for the first line" so when converting from bnd location > build context we need to add one to the line.