Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix RunRequirements could not be saved #6449

Merged

Conversation

chrisrueger
Copy link
Contributor

@chrisrueger chrisrueger commented Jan 29, 2025

Closes #6448
The problem was that before this fix the call to super.commit(onSave); has reset the dirty flag from true back to false, which was the reason why commitToModel(onSave); did not work, because it checks for dirty==true

@stbischof could you test the PR?

The problem was that before this fix the call to super.commit(onSave); has reset the dirty flag from true back to false, which was the reason why commitToModel(onSave); did not work, because it checks for dirty==true

Signed-off-by: Christoph Rueger <[email protected]>
@chrisrueger chrisrueger marked this pull request as ready for review January 29, 2025 18:46
@stbischof
Copy link
Contributor

I never tested a snapahot of bnd that was selfbuild. Could you help me how to test

@chrisrueger chrisrueger merged commit 62c11bb into bndtools:master Jan 29, 2025
9 checks passed
@chrisrueger
Copy link
Contributor Author

chrisrueger commented Jan 29, 2025

@stbischof I took the liberty to merge it to master, since the change was small. Snapshot should be available in a few minutes... e.g. 30m.

Please test this. In case something broke, I can revert it.

I never tested a snapahot of bnd that was selfbuild. Could you help me how to test

a bit short on time atm. I think there is a description somewhere, but I have to admint, I cannot remember how exactly too. I usually checkout other PRs and have the bndtools dev environment setup. But this is probably not your situation, since you are more of a user.

@chrisrueger
Copy link
Contributor Author

Found it: https://bndtools.org/development.html : "Importing Into Eclipse"
you only need to checkout the branch of the PR and build it
https://docs.github.com/de/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

But honestly, I need to try it myself too :)

@stbischof
Copy link
Contributor

Currently snapahot is not deployed

@chrisrueger
Copy link
Contributor Author

I believe it is. I just got it.

  • select Bndtools in Eclipse Installation Details
  • press the update button

image

I think it is
Bndtools 7.2.0.DEV-202501291916-g62c11bb bndtools.main.feature.feature.group Bndtools

@stbischof
Copy link
Contributor

Works on m Maschine

@stbischof
Copy link
Contributor

Thnk you a lot!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bndrun UI: Cant save added requirebundles
2 participants