Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/parity #2

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Feature/parity #2

wants to merge 11 commits into from

Conversation

Ujang360
Copy link

@Ujang360 Ujang360 commented Mar 19, 2020 •
edited
Loading

Tasks:

  • Replace geth with parity for safer alternative
  • Add Ropsten (Tesnet) config for default
  • Adjust Dockerfile
  • Adjust README.md
  • Adjust scripts
  • Sync & JSON-RPC Manual Test

@Ujang360 Ujang360 added the enhancement New feature or request label Mar 19, 2020
@Ujang360 Ujang360 self-assigned this Mar 19, 2020
@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 20, 2020
@nevrending
Copy link
Contributor

Btw, what if we keep 2 mainlines for bitwyre/crypto-ethereum?
Say geth-1.9.11 etc and parity-2.7.2 etc

And also is it possible to make parity "configureable" via runtime args?
e.g for geth, if we want to launch it in testnet mode, we can just run the container with command override to --testnet --rpc

@Ujang360
Copy link
Author

Btw, what if we keep 2 mainlines for bitwyre/crypto-ethereum?
Say geth-1.9.11 etc and parity-2.7.2 etc

And also is it possible to make parity "configureable" via runtime args?
e.g for geth, if we want to launch it in testnet mode, we can just run the container with command override to --testnet --rpc

Thats a good idea

@Ujang360 Ujang360 changed the title [WIP] Feature/parity Feature/parity Mar 20, 2020
@Ujang360 Ujang360 marked this pull request as ready for review March 20, 2020 04:45
@Ujang360
Copy link
Author

This PR already support runtime args, for parity.

Please Don't Merge This Yet

nevrending
nevrending suggested changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@nevrending nevrending left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevrending nevrending nevrending requested changes

@dendisuhubdy dendisuhubdy dendisuhubdy approved these changes

Assignees

@Ujang360 Ujang360

Labels
enhancement New feature or request size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ujang360 @nevrending @dendisuhubdy