BUGFIX: Editor shows error popup when opening scripts on "." server #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Superseded by #1893. |
catloversg
deleted the
pull-request/bugfix/editor-shows-error-popup-when-opening-scripts-on-dot-server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regression bug appeared when we updated monaco-editor in #1468.
How to reproduce it: Open any scripts on "." server.
Relevant code:
https://github.com/microsoft/TypeScript/blob/56a08250f3516b3f5bc120d6c7ab4450a9a69352/src/compiler/path.ts#L632-L649
file:///./a.jsis normalized tofile:///a.js, but the model URI is stillfile:///./a.js. With another scheme (e.g., "memory"),normalizePathdoes not strip the "./" part. For example, with "memory" scheme, URI of "a.js" in "." server ismemory:./a.js.If you are curious about why it does not happen in old version, you can check the change in
getOrCreateSourceFileByPathin microsoft/TypeScript@5aa0053.