IPVGO: Support scripts playing against each other as each color on "No AI" boards #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I look forward to implementing this in my script and so do many other people. |
… controlled territory max space
d0sboots
reviewed
Jan 26, 2025
d0sboots
reviewed
Jan 28, 2025
There was a problem hiding this comment.
Every time I have to review this, I have to pull the full state of how the promise stuff works back into cache. XD I think I almost have a coherent set of suggestions to make, but I'm still ruminating. Pulling everything together into a single update method is the right plan.
Fixes the issue where handicap stones are added on game load. Better typing for error callbacks. Throw errors instead of deadlocking on bad cheat usage.
This greatly simplifies the code by running everything through handleNextTurn() (formerly makeAIMove()). The nextTurn promises for both sides are handled identically, without special-casing. Even the built-in AI is largely color-agnostic, with only one place that is hardcoded to white.
This tweaked something unstable in Gameboard, the new condition is much more stable for determining when to show the score dialog.
|
I went through and resolved all the comments I handled in my PR, which was all of them XD |
…inst_other_scripts
…white_against_other_scripts IPVGO: PR on a PR
…s_playing_as_white_against_other_scripts
…white_against_other_scripts Test fixes
antoinedube
pushed a commit
to antoinedube/bitburner-source
that referenced
this pull request
Feb 5, 2025
…o AI" boards (bitburner-official#1917) This is a big change with a *lot* of moving parts. The largest part of it is enabling scripts to `playAsWhite` as a parameter to many Go functions. In the implementation, this involved a significant rewrite of `opponentNextTurn` promise handling. A number of other changes and bugfixes are included: * Fixes the issue where handicap stones are added on game load. * Better typing for error callbacks. * Throw errors instead of deadlocking on bad cheat usage. * Return always-resolved gameOver promise after game end * Added a new `resetStats` api function. --------- Co-authored-by: David Walker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch testable here: https://ficocelliguy.github.io/bitburner-src/
A few people in discord have asked for the ability to pit multiple IPvGO scripts against each other. This is the most recent:
https://discord.com/channels/415207508303544321/1221920484111814828/1330501717674168423
This PR adds support for making moves as the white player via the API. This can only be done on the "No AI" practice board, which gives no stats. To do this, additional promise handling was added so that the two scripts could listen for when the other script (or player via UI) has made a move.
In addition, documentation improvements and a new Go.analytics.getHistory() method were added to resolve this feedback:
Closes #1576