Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): ajouter la dépendance exceljs for dev #4402

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

naustra
Copy link
Collaborator

@naustra naustra commented Oct 2, 2024

No description provided.

@naustra naustra changed the title feat(api): ajouter la dépendance exceljs for dev chore(api): ajouter la dépendance exceljs for dev Oct 2, 2024
Copy link

codeclimate bot commented Oct 2, 2024

Code Climate has analyzed commit 1c555cb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 45.2%.

View more on Code Climate.

Copy link
Collaborator

@achorein achorein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pourquoi ajouter cette lib alors qu'on a déjà "xlsx": "~0.18.5", il faudrait choisir l'une au l'autre non ?

@naustra
Copy link
Collaborator Author

naustra commented Oct 4, 2024

C'est pour le repo script. On avait besoin d'une gestion de la couleur sur les excels qu'apparemment xlsx ne gère pas.
@achorein c'est pour éviter d'installer un package a la mano quand on run un des scripts d'affectation. Ça peut ralentir le prochain en run si on merge pas

@naustra
Copy link
Collaborator Author

naustra commented Oct 4, 2024

c'est @hlecourt qui a codé le script. Il peut t'en dire plus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants