Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin): 3205 - Fix reviews UI pages "mes-eleves" + adding the banner on result #4305

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Eric013
Copy link
Collaborator

@Eric013 Eric013 commented Sep 12, 2024

Fix reviews UI pages "mes-eleves" + adding the banner "Vous constatez une différence entre les résultats ?"

Description

Correction des retours UI sur la page mes-élèves et ajouter un bandeau "Vous constatez une différence entre les résultats ?"

Todo

  • possible d’aligner le texte “étape X” avec le texte de l’onglet en dessous (ex : étape 1 aligné à gauche avec Récolte...)
  • lorsque la liste est vide : icon avec trait de 1.5 px
  • supprimer le contour gris du bouton bleu rond OK
  • Ajouter le bandeau d’infos en haut de l’ecran

Ticket / Issue

Testing instructions

  • Prendre la place d'un référent de classe et Aller sur la page "Mes éleves"
  • Pour la partie UI, vérifier le bandeau des différentes étapes
  • Pour le bandeau vérifier sa présence tout en haut de la page

@Eric013 Eric013 self-assigned this Sep 12, 2024
@Eric013 Eric013 added UI/UX front style ADMIN labels Sep 12, 2024
1 similar comment
Copy link
Collaborator

@achorein achorein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
quelques commentaires sur la forme

packages/ds/src/admin/layout/Navbar.tsx Outdated Show resolved Hide resolved
packages/ds/src/admin/layout/Navbar.tsx Outdated Show resolved Hide resolved
packages/ds/src/admin/layout/Navbar.tsx Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Sep 26, 2024

Code Climate has analyzed commit 383ec9d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 45.3% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADMIN UI/UX front style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants