Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add the textfield to write X legend of chart #61

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mtgto
Copy link
Collaborator

@mtgto mtgto commented Nov 16, 2019

Set X legend to chart.

legend

Current, the legend is not saved in DB. I can't find a way to migrate DB.
It is the reason this PR is WIP.

@hokaccha
Copy link
Member

I can't find a way to migrate DB.

Bdash has never migrated DB before 😓 I would like to introduce a mechanism like ridgepole, but it will be difficult right now.

It's not a beautiful solution, but the method of Jasper may be the easiest.
https://github.com/jasperapp/jasper/blob/cebf1f3912d03b59ac4cd3afb152bfaeb27a8f9d/src/Bootstrap.ts#L125-L136

I think this way is better now. Do you have any ideas?

@mtgto
Copy link
Collaborator Author

mtgto commented Nov 28, 2019

I like Jasper way.
Released app doesn't have complicated migration generations.
The version of Bdash DB increases simple.

In addition, keeping current DB version in DB or configuration, we can reduce the count of migration to minimum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants