Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packagegroup-balena-connectivity: Install linux-firmware-ath10k by de… #3608

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

acostach
Copy link
Contributor

@acostach acostach commented Feb 5, 2025

…fault

Some devices may use wifi chips which need this firmware. Let's include it by default and then remove it for those boards that currently don't have sufficient rootfs space for now, or already include this package from the device repository.

Change-type: patch


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

…fault

Some devices may use wifi chips which need this firmware. Let's include it by default and then remove it for those boards that currently don't have sufficient rootfs space for now, or already include this package from the device repository.

Change-type: patch
Signed-off-by: Alexandru Costache <[email protected]>
@acostach acostach requested a review from a team February 5, 2025 09:22
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:22 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:23 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:23 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:23 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 09:23 — with GitHub Actions Inactive
@acostach acostach enabled auto-merge February 5, 2025 09:23
Copy link
Contributor

flowzone-app bot commented Feb 5, 2025

Website deployed to CF Pages, 👀 preview link https://e7e28ff9.balena-os.pages.dev

@rcooke-warwick
Copy link
Contributor

@acostach looks like the beagle device types get tipped over the edge by including this firmware

@acostach acostach temporarily deployed to balena-staging.com February 5, 2025 13:26 — with GitHub Actions Inactive
@acostach
Copy link
Contributor Author

acostach commented Feb 5, 2025

Indeed, balena-os/balena-beaglebone#701 will need to be merged first to remove this for the Beaglebone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants