feat: voting list #148
Open
feat: voting list #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/lib/modules/pool/PoolDetail/PoolHeader/PoolMetaBadges.tsx
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
garethfuller
requested changes
Nov 7, 2024
packages/lib/modules/vebal/vote/hidden-hand/hidden-hand.type.ts
Outdated
Show resolved
Hide resolved
Comment on lines
32
to
36
| const { | ||
| data: votingIncentives, | ||
| isLoading: votingIncentivesLoading, | ||
| error: votingIncentivesError, | ||
| } = useHiddenHandVotingIncentives() |
There was a problem hiding this comment.
Any fetching that can be done server-side, e.g to external APIs or our own can be done in the RSC/layout component and passed into providers as inputs.
There was a problem hiding this comment.
You should be fetching data in this component and passing it into providers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds vebal voting list
