Merge pull request #158 from balancer/fix/lint

fix: part of lint warnings
balancer · Nov 11, 2024 · 140183e · 140183e
2 parents ca1f61b + dd53c0f
commit 140183e
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 10 deletions.
diff --git a/packages/lib/modules/portfolio/PortfolioTable/PortfolioTableHeader.tsx b/packages/lib/modules/portfolio/PortfolioTable/PortfolioTableHeader.tsx
@@ -38,7 +38,7 @@ export function PortfolioTableHeader({ currentSortingObj, setCurrentSortingObj,
         <SortableHeader
           align={index === 0 ? 'left' : 'right'}
           isSorted={orderByItem.id === currentSortingObj.id}
-          key={index}
+          key={orderByItem.id}
           label={orderByItem.title}
           onSort={() => {
             if (orderByItem.id === currentSortingObj.id) {

diff --git a/packages/lib/modules/vebal/lock/VebalLockProvider.tsx b/packages/lib/modules/vebal/lock/VebalLockProvider.tsx
@@ -169,7 +169,7 @@ export function _useVebalLock() {
   }
 }
 
-export function VebalLockProvider({ children }: PropsWithChildren & {}) {
+export function VebalLockProvider({ children }: PropsWithChildren) {
   const vebalLock = _useVebalLock()
 
   return <VebalLockContext.Provider value={vebalLock}>{children}</VebalLockContext.Provider>

diff --git a/packages/lib/modules/vebal/lock/form/VebalUnlockForm.tsx b/packages/lib/modules/vebal/lock/form/VebalUnlockForm.tsx
@@ -92,7 +92,6 @@ export function VebalUnlockForm() {
                 <TokenRowWithDetails
                   address={vebalBptToken.address as Address}
                   chain={GqlChain.Mainnet}
-                  value={mainnetLockedInfo.lockedAmount ?? 0}
                   details={
                     lockDuration.lockedUntilDateFormatted
                       ? [
@@ -107,6 +106,7 @@ export function VebalUnlockForm() {
                         ]
                       : undefined
                   }
+                  value={mainnetLockedInfo.lockedAmount ?? 0}
                 />
               </Card>
             )}

diff --git a/packages/lib/modules/vebal/lock/modal/VebalLockModal.tsx b/packages/lib/modules/vebal/lock/modal/VebalLockModal.tsx
@@ -84,6 +84,7 @@ export function VebalLockModal({
       isIncreasedLockAmount: isIncreasedLockAmount,
       mainnetLockedInfo: mainnetLockedInfo,
     })
+    /* eslint-disable-next-line react-hooks/exhaustive-deps */
   }, [isOpen, userAddress])
 
   const { transactionSteps, lockTxHash } = useBuildLockSteps(buildLockStepsArgs)

diff --git a/packages/lib/modules/vebal/lock/steps/useLockStep.tsx b/packages/lib/modules/vebal/lock/steps/useLockStep.tsx
@@ -89,22 +89,21 @@ export function useLockStep({ lockAmount, lockEndDate, lockActionType }: UseLock
 
   const transaction = getTransaction(lockActionType)
 
-  const isComplete = () => transaction?.result.isSuccess || false
-
   const [isStepActivated, setIsStepActivated] = useState(false)
 
   const lockStep: TransactionStep = useMemo(
     () => ({
+      isStepActivated,
       id: lockActionType,
       stepType: lockActionType,
       labels,
-      isComplete,
+      isComplete: () => transaction?.result.isSuccess || false,
       onSuccess,
       onActivated: () => setIsStepActivated(true),
       onDeactivated: () => setIsStepActivated(false),
       renderAction: () => <ManagedTransactionButton id={lockActionType.toString()} {...props} />,
     }),
-    [lockActionType, labels, isComplete, onSuccess, props]
+    [lockActionType, labels, onSuccess, props, transaction, isStepActivated]
   )
 
   return lockStep

diff --git a/packages/lib/modules/vebal/vebal-chart/useVebalLocksChart.tsx b/packages/lib/modules/vebal/vebal-chart/useVebalLocksChart.tsx
@@ -11,7 +11,6 @@ import BigNumber from 'bignumber.js'
 import { UseVebalLockInfoResult } from '../../vebal/useVebalLockInfo'
 import { bn, fNum } from '@repo/lib/shared/utils/numbers'
 import { useTheme as useNextTheme } from 'next-themes'
-import { useVebalLockData } from '@repo/lib/modules/vebal/lock/VebalLockDataProvider'
 
 type ChartValueAcc = [string, number][]
 

diff --git a/packages/lib/shared/hooks/useAprTooltip.ts b/packages/lib/shared/hooks/useAprTooltip.ts
@@ -19,9 +19,13 @@ prevents this loss (also called LVR), thereby increasing LP returns.`
 export const extraBalTooltipText = `veBAL holders can get an extra boost of up to 2.5x on their staking yield.
 The more veBAL held, the higher the boost.`
 
-export const lockingIncentivesTooltipText = `The protocol revenue share for Liquidity Providers with 1-year locked Balancer ve8020 tokens.`
+export const lockingIncentivesTooltipText = `The protocol revenue share for Liquidity Providers 
+                                            with 1-year locked Balancer ve8020 tokens.`
 
-export const votingIncentivesTooltipText = `Vote incentives are offered to veBAL holders who participate in weekly gauge voting by third parties on platforms like Hidden Hand. Your incentives are determined by your veBAL voting power compared to other voters. The listed APR represents an average rather than a guaranteed return for active participants.`
+export const votingIncentivesTooltipText = `Vote incentives are offered to veBAL holders who 
+                        participate in weekly gauge voting by third parties on platforms like Hidden Hand. 
+                        Your incentives are determined by your veBAL voting power compared to other voters. 
+                        The listed APR represents an average rather than a guaranteed return for active participants.`
 
 const stakingBalTooltipText = `The base APR all stakers in this pool get (determined by weekly gauge voting).
 In addition, veBAL holders can get an extra boost of up to 2.5x.`