Auto Mode #459

alejot127 · 2022-06-28T19:28:36Z

Still working on some kinks, but this is my general approach. Threads in Kotlin are new to me as well, so maybe there's a better way to do this + I may be doing it way wrong

…igs. * Incorporate default fixture and transport configs into brain controllers. * Clean up UI. * Backfill some tests.

…fixture type is. * Automatic DMX assignments. * Rename FixtureMappingData.deviceType to fixtureType.

* Catch and display fixture config errors instead of blowing up. * Honcho scene uses auto DMX allocation.

In-app controller configuration

Swap simulator and app positions for small devices.

Apply entity transformation to its pixel locations

Apply parent transforms

Persist client app mode

Matrices used to be stored as an object with an "elements" array; now they're just an array.

Accepted files still aren't properly identified, at least in dev, because file names and types seem to be unavailable?

Shows and scenes can be uploaded through UI

…normal comments as plugin references.

https://www.shadertoy.com/view/Mss3zH — mouse.xy = mouse position during last button down abs(mouse.zw) = mouse position during last button click sign(mouze.z) = button is down sign(mouze.w) = button is clicked

… the webgl context limit is quickly breached.

…t file.

Misc fixes

build.gradle.kts

src/commonMain/kotlin/baaahs/show/live/AutoMode.kt

xian · 2022-07-02T04:13:42Z

src/commonMain/kotlin/baaahs/show/live/AutoMode.kt

+    private suspend fun playWithButtons() {
+        val controls: List<OpenButtonControl> = openShow.allFilterButtonControls
+        logger.info { "Controls " + controls.joinToString { it.gadget.title } }
+        val random = Random(indexSeed++)


You could store the Random as a private var if you want, no need really to reinitialize it every time, you'll keep getting pseudo-random numbers forever.

Fwiw I don't usually bother with creating explicit Randoms unless unit tests interact with it, in which case they're awesome.

Yeah not sure how to get truly random results since the seed is always the same, so the auto mode will always pick the same number sequence :/

One solution is to get the current time in seconds as the seed to always get diff results, but I couldn't reference this for some reason: https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.system/get-time-millis.html

xian · 2022-07-02T04:27:51Z

src/commonMain/kotlin/baaahs/show/live/AutoMode.kt

+        var control: OpenButtonControl
+        while (autoModeOn) {
+            control = controls.random(random)
+            // This doesn't update the UI :(


Huh, yeah, janky. It definitely seems like click() ought to do what you want.

There are a couple ways the button might be enabled/disabled:

when a user directly clicks on it. In this case, ButtonControlView calls handleToggleClick(), which calls button.click(), but also onShowStateChange(), which ultimately calls ShowManager.Facade.onShowStateChange(), which re-renders the page.

when a user on another client clicks it. In this case, I'm not quite sure exactly how the UI gets updated; I think it's something like this: the switch gadget gets an update over pubsub, then notifies its observers, which include GadgetManager, which is itself being observed by StageManager, which ... somehow magically causes a re-render. I'm missing something there clearly. I'll look more closely in a few.

In short, this is all kinda a spaghetti-tastic mess. Thinking about how to improve matters.

xian · 2022-07-02T04:29:47Z

src/commonMain/kotlin/baaahs/show/live/AutoMode.kt

+        logger.info { "Stop Called" }
+        autoMode = false;
+        CoroutineScope(Dispatchers.Unconfined).launch {
+            gadgetWizard?.cancelAndJoin()


xian · 2022-07-02T04:46:08Z

src/jsMain/kotlin/baaahs/app/settings/UiSettings.kt

@@ -6,6 +6,7 @@ import kotlinx.serialization.Serializable
 @Serializable
 data class UiSettings(
    val darkMode: Boolean = true,
+    val autoMode: Boolean = false,


I think autoMode makes more sense as show state rather than client config state. UiSettings is meant for config on the local client, and doesn't get synched to other open clients, but you probably want autoMode to show the same value on every open client. Otherwise there'd be no way to stop an unattended iPad from monkeying with your show.

Thinking about it a little more, implementing it that way actually raises some weird issues: it implies that some single entity needs to be in charge of the monkeying, which makes me think it really should be happening on the server. Further, if there's no client currently connected I think we'd still like monkeying to happen potentially, another vote in favor of the server doing it.

... which would require rethinking our approach a little bit. Maybe it makes sense to get it working as-is since time grows short. 🤷‍♀️

xian · 2022-07-02T04:47:03Z

src/commonMain/kotlin/baaahs/show/live/OpenPatch.kt

@@ -37,6 +37,13 @@ class OpenPatch(
            }
        }

+    val inEqualsOut: Boolean


Any insight into why isFilter seemed to be behaving badly?

So isFilter might be fine, this was before I tried to fetch controls from the openlayout, which doesn't include the "backdrop" control group.

Ah okay, I bet it doesn't traverse into children.

xian · 2022-07-13T20:38:00Z

data/config.json

Not sure this should be a persisted server setting.

If Pinky restarts, maybe we start in auto mode==true until we get some client interaction? Anyway, not a big deal either way, but it doesn't feel like important state to save between restarts.

xian · 2022-07-13T20:40:43Z

src/commonMain/kotlin/baaahs/control/ButtonControl.kt

@@ -126,6 +126,11 @@ class OpenButtonControl(
        isPressed = !isPressed
    }

+    fun forceClickChange() {
+        click()
+        switch.changed()


Yeah, good workaround. Could you drop in a comment saying it's a workaround for listeners not being quite right?

(Eventually I'd like to clean up the listeners so it does the right thing on its own.)

xian · 2022-07-13T20:43:51Z

src/commonMain/kotlin/baaahs/show/live/OpenPatch.kt

@@ -37,6 +37,13 @@ class OpenPatch(
            }
        }

+    val inEqualsOut: Boolean


Ah okay, I bet it doesn't traverse into children.

xian · 2022-07-13T20:45:40Z

src/commonMain/kotlin/baaahs/sm/server/StageManager.kt

@@ -205,6 +225,8 @@ class StageManager(
            updateRunningShowPath(file)

            notifyOfDocumentChanges(fromClientUpdate)
+
+            autoModeWizard.setShow(showRunner!!.openShow)


You can get this behavior by giving AutoMode a ShowMonitor:

class AutoMode(showMonitor: ShowMonitor) { init { showMonitor.addObserver { setShow(it.openShow) } } ... }

xian · 2022-07-13T20:46:39Z

src/commonMain/kotlin/baaahs/sm/webapi/WebApi.kt

@@ -12,6 +13,9 @@ data class ClientData(
    val fsRoot: Fs.File
 )

+@Serializable
+class AutoModeCommand(val autoModeState: AutoModeState)


I think you don't need this, just the AutoModeState channel.

xian · 2022-07-13T20:48:13Z

src/jsMain/kotlin/baaahs/client/WebClient.kt

+            logger.info { "Successful subscribe then publish" }
+            val newMode = newAutoMode == AutoModeState.On
+            val newSettings = uiSettings.copy(autoMode = newMode)
+            updateUiSettings(newSettings, saveToStorage = true)


I'd just make this a property on the facade rather than putting it in UiSettings, cuz it doesn't need to be persisted across browser reloads — the one source of truth should be the pubsub channel.

var autoModeState = AutoModeState.OFF pubSub.subscribe(Topics.autoMode) { newAutoMode -> automodeState = newAutoMode facade.notifyChanged() }

xian · 2022-08-10T22:04:14Z

Sorry I'm so slow! Failing tests here, I can help look a little later for clues…

xian and others added 30 commits March 4, 2022 13:45

Rename DeviceType to FixtureType throughout.

eb860b6

Clean up controller config UI.

7ed0245

Fix handling of empty numberTextFields.

f92ebe5

Fix updating in pixel array config editor.

da417d6

Add default fixture and transport configs for controllers.

72cca53

Updated SparkleMotion simulator gif

3f95765

Update README.md

6505e49

Update README.md

f9abd84

Controllers can be configured with default fixture and transport conf…

8309f86

…igs. * Incorporate default fixture and transport configs into brain controllers. * Clean up UI. * Backfill some tests.

Fix simulator's "Patience" loading bumper.

b84644e

Use controller defaults to DRY up Honcho.scene.

31cd7d6

Fixture mappings must include a fixture config so we know what their …

b6d4f5c

…fixture type is. * Automatic DMX assignments. * Rename FixtureMappingData.deviceType to fixtureType.

DMX addresses can be auto-allocated.

0b69c39

Fix bug saving stuff to browser sandbox fs.

d6e2d44

Show computed DMX channels when auto-allocated.

d735896

* Catch and display fixture config errors instead of blowing up. * Honcho scene uses auto DMX allocation.

Merge pull request #427 from baaahs/controllers-editor

f3aab67

In-app controller configuration

Rename FixtureInfo.matrix to .transformation (and deprecate matrix).

6cb4f5a

Update SimulatorAppView.kt

b2e09ce

Swap simulator and app positions for small devices.

Apply model entities' transformations to pixels.

6a82aff

Remove deprecated FixtureInfo.origin/heading/matrix.

e61e9b1

Merge pull request #429 from baaahs/apply-model-transformation

c5d344f

Apply entity transformation to its pixel locations

Fix light ring pixel visualization.

5ef74f1

Move specs that don't rely on JVM to commonTest.

4c10a56

Apply transformations from parent model entities.

4f2d3bd

Merge pull request #430 from baaahs/apply-parent-transforms

eae78fc

Apply parent transforms

Persist client app mode.

f1956e3

Merge pull request #431 from baaahs/persist-app-mode

c2900f5

Persist client app mode

use node 16 for M1

ac4f16a

Fix loading of session mapping data.

9354d4c

Matrices used to be stored as an object with an "elements" array; now they're just an array.

Fix Pinky's --simulateBrains mode.

dd387be

xian and others added 15 commits June 27, 2022 13:45

Support for uploading shows and scenes.

51a0ab3

Dropzone/file upload cleanup.

6acbd94

Accepted files still aren't properly identified, at least in dev, because file names and types seem to be unavailable?

Upload data is a string.

df25780

Add shadow behind control edit and delete buttons for legibility.

4746d07

Slider ticks include fraction when tick scale is 1x.

c4d5ca5

Show preview slider in slider props editor.

5f07358

Merge pull request #457 from baaahs/file-upload

46a9ec8

Shows and scenes can be uploaded through UI

Fix bug in GLSL hint resolution that was causing attempts to resolve …

cf5d02a

…normal comments as plugin references.

Per ShaderToy, iMouse is a vec4.

229b3ab

https://www.shadertoy.com/view/Mss3zH — mouse.xy = mouse position during last button down abs(mouse.zw) = mouse position during last button click sign(mouze.z) = button is down sign(mouze.w) = button is clicked

Self-referencing macros cause 'splosions.

506fbbf

GLSL function params may start with underscores.

828c266

We need to wrap the shader library previews in a shared GL context or…

3a30dc7

… the webgl context limit is quickly breached.

Nicer error message when shader library index refers to a non-existen…

a4a4b6f

…t file.

Merge pull request #458 from baaahs/misc-fixes

2c45c5c

Misc fixes

Merge branch 'main' into alejo

ea86dd5

alejot127 requested a review from xian June 28, 2022 19:28

alejot127 added 3 commits June 28, 2022 12:29

auto mode first go

a2bcebf

refactor

a5cda6e

only controls on current tab layout

4ff2f5a

xian reviewed Jul 2, 2022

View reviewed changes

automode clicks update UI

0c445c3

xian reviewed Jul 13, 2022

View reviewed changes

alejot127 added 3 commits July 26, 2022 18:45

remove UI switch + replace with last user action timer

5ddecc4

more clean up

42cae4d

fixed illegalstate bug but removed pub/sub on automode topic

c623c06

alejot127 changed the title ~~WIP: Auto Mode~~ Auto Mode Jul 28, 2022

xian force-pushed the main branch from 7dfe341 to bbe7cb1 Compare July 27, 2024 13:58

xian force-pushed the main branch from d142fa5 to 1873ba9 Compare December 9, 2024 04:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto Mode #459

Auto Mode #459

alejot127 commented Jun 28, 2022

xian Jul 2, 2022

alejot127 Jul 3, 2022

xian Jul 2, 2022

xian Jul 2, 2022

xian Jul 2, 2022

xian Jul 2, 2022

alejot127 Jul 3, 2022

xian Jul 13, 2022

xian Jul 13, 2022

alejot127 Jul 13, 2022

xian Jul 13, 2022

xian Jul 13, 2022

xian Jul 13, 2022

xian Jul 13, 2022

xian Jul 13, 2022

xian Jul 13, 2022

xian commented Aug 10, 2022

Auto Mode #459

Are you sure you want to change the base?

Auto Mode #459

Conversation

alejot127 commented Jun 28, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xian commented Aug 10, 2022