fix: some vim plugins get disabled by mistake

[Jint-lzxy]

This commit addresses a few regressions introduced by #1340:

• The tutor plugin was accidentally disabled.
• netrw, along with its configuration, was mistakenly disabled.
• EditorConfig is now being implicitly disabled, which wasn't intended before fix(core): disable rtp plugins via lazy.nvim, #1339 #1340.

[CharlesChiuGit]

EditorConfig is not disabled currently.

[CharlesChiuGit]

i thought we use nvim-tree as netrw, no?
or it's necessary to load builtin netrw?

[ayamir]

I don't use editorconfig, so I can't judge if it works for fine.
And as the readme of nvim-tree said, disabling netrw is strongly advised.

[Jint-lzxy]

Sorry for the late reply! I've had a lot to sort through over the past few days lol

EditorConfig is not disabled currently

Oops, that was enabled by mistake. Sorry for the extra noise introduced with this PR! I somehow forgot we already have sleuth.vim lmao

i thought we use nvim-tree as netrw, no?
or it's necessary to load builtin netrw?

nvim-tree isn't actually hijacking netrw during startup cuz it's intended to be loaded on demand. So if we disable netrw, users might encounter issues when trying to open directories with neovim at startup. Alternatively, we could configure nvim-tree to hijack netrw, but that would likely cause a noticeable increase in startup time¹.

And as the readme of nvim-tree said, disabling netrw is strongly advised.

Hmm, I think this ultimately comes down to personal preference cuz afaiu netrw is generally useful for opening a directory with neovim (like nvim .) at startup, which is significantly faster than using nvim-tree¹ and doesn't come with a huge deficit in features compared to nvim-tree. In most other cases, nvim-tree handles things well.

Footnotes

1. That's what happens on my devices, tho I'm not sure if it's different with other software and hardware combos. ↩ ↩²

[Jint-lzxy]

0b6dc57 reintroduces load_distribution_plugins and adds a warning about enabling editorconfig.lua:

Sleuth.vim already includes all the features provided by this plugin.
Do NOT enable both at the same time, or you risk breaking the entire detection system.

I've kept netrw enabled for now, but I'm open to changing that whenever lol

[ayamir]

Fine for me.

[aarnphm]

tested with builtin editorconfig seems to work (as I don't use sleuth.vim).

[CharlesChiuGit]

LGTM

[CharlesChiuGit]

we can't disable builtin editorconfig via global options, if we use lazy.nvim.
we can only get a valid disable via lazy.nvim.

[CharlesChiuGit]

tbh, i think we don't need vim-sleuth since we now have a builtin editorconfig.
how do u guys think? @ayamir @Jint-lzxy @aarnphm
ppl should use after/ftplugin or native editorconfig syntax.

[aarnphm]

sgtm. always +1 when removing plugins.

[ayamir]

tbh, i think we don't need vim-sleuth since we now have a builtin editorconfig.

vim-sleuth is useful for me b/c I don't use editorconfig lol

[CharlesChiuGit]

ok lol
then i think it's ready to merge.